Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Systemd template #325

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jclusso
Copy link
Contributor

@jclusso jclusso commented Jan 24, 2025

  • Added back comments
  • Added MALLOC_ARENA_MAX=2 a default ENV var
  • Added missing options

- Added back comments
- Added MALLOC_ARENA_MAX=2 a default ENV var
- Added missing options
Comment on lines +71 to +76
# Uncomment this if you are going to use this as a system service
# if using as a user service then leave commented out, or you will get an error trying to start the service
# !!! Change this to your deploy user account if you are using this as a system service !!!
# User=deploy
# Group=deploy
# UMask=0002
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seuros I'm confused with what values these should be set to. There are some various different users like service_unit_user, systemctl_user (which defaults to a boolean value?), sidekiq_lingering_user, and maybe more I haven't found yet?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service_unit_user was introduced to create a unified approach for defining the service unit user across all the Capistrano gems. We could adopt it now and mirror it in the Puma gem as well for consistency.

Regarding the lingering concept, it’s designed to allow the systemd file to be located in the user’s home directory. This is particularly useful for deployments where the user doesn’t have sudo access or the ability to write to the systemd folder.

I appreciate your help btw.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I don't understand 100%, but would we replace systemctl_user with service_unit_user? At the bottom of the template there is also sidekiq_systemctl_user which seems to set WantedBy based on if that is :system or not. This seems like it's supposed to correlate in some capacity with the highlighted section here where I'm trying to determine what User and Group should be.

Right now there isn't any comments or documentation on all of these possible configuration options so it's a bit confusing cause there are so many "user" related ones. If you could add all the possible options to readme or something, that would be very helpful.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check #326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants