Fix: Voice response cannot be decoded #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorlif
commented
Feb 11, 2025
| @@ -25,7 +26,7 @@ type Voice struct { | |||
| type VoiceMessage struct { | |||
| Error *string `json:"error"` | |||
| ErrorText *string `json:"error_text"` | |||
| Id *string `json:"id"` | |||
| Id *int64 `json:"id"` | |||
There was a problem hiding this comment.
I was unsure how large the value could be. If it is a database ID, I can imagine that it will be quite high, which is why I chose int64.
There was a problem hiding this comment.
@vorlif it is supposed to become quite high indeed, so int64 seems good to me :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: The response for an API voice call cannot be decoded because the message ID is a number and not a string.
I replaced the
stringwith anint64value and added tests based on the API documentation to make sure everything works.