Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't bind to 'min' since it isn't a known property of 'fwt-slider' #8

Open
peterennis opened this issue Dec 13, 2018 · 9 comments
Open

Comments

@peterennis
Copy link

@seveves

Updating to A7 shows the following with ng test:

Failed: Template parse errors:
Can't bind to 'min' since it isn't a known property of 'fwt-slider'.
1. If 'fwt-slider' is an Angular component and it has 'min' input, then verify that it is part of this module.
2. If 'fwt-slider' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to suppress this message.
3. To allow any property add 'NO_ERRORS_SCHEMA' to the '@NgModule.schemas' of this component. ("<div style="text-align:center">
  <fwt-slider [ERROR ->][min]="min" [max]="max" [value]="value1" (valueChanged)="onValue1Changed($event)"></fwt-slider>
  <f"): ng:///DynamicTestModule/AppComponent.html@1:14

capture463

@peterennis
Copy link
Author

From here:
https://blog.angular.io/version-7-of-angular-cli-prompts-virtual-scroll-drag-and-drop-and-more-c594e22e7b8c
ng update @angular/cli @angular/core

From here:
angular/angular-cli#12215
ng update @angular/cli --migrate-only --from=1.7.4

Current state here:
peterennis@31ac6d0

NOTE: Results of npm audit

found 15 vulnerabilities (9 low, 6 high) in 39120 scanned packages
  run `npm audit fix` to fix 3 of them.
  12 vulnerabilities require semver-major dependency updates.

@peterennis
Copy link
Author

Run npm install --save-dev [email protected] to resolve 12 vulnerabilities
SEMVER WARNING: Recommended action is a potentially breaking change

C:\ae\aedev\angular-stencil\angular>npm audit

                       === npm audit security report ===

found 0 vulnerabilities
 in 40198 scanned packages

@peterennis
Copy link
Author

npm start
capture464

@peterennis
Copy link
Author

capture465

@peterennis
Copy link
Author

fwt-slider-component

@peterennis
Copy link
Author

@seveves - Builds of Angular and Stencil are working to latest versions.

Todo: Integrate component with version information into the Angular app, run tests and verify.
Apply fixes and update documentation as needed.

Dev/Test work in this branch: https://github.com/peterennis/angular-stencil/tree/ae

Angular is still using the old component at present:
fwt-slider-a7

@peterennis
Copy link
Author

@seveves - Fixed
fwt-slider-a7-fixed

This commit: peterennis@af8d19a

Todo: Update documentation

@peterennis
Copy link
Author

@seveves
Documentation finished.
Updated here: peterennis@8f26c06
Please review and I will update the master branch for the PR.

@peterennis
Copy link
Author

@seveves
Updated to use stencil-component-starter
Updated here: peterennis@119f67e

Stencil now uses testing with E2E/Jest/Puppeteer
but that is outside the current scope.
Maybe future work?

NOTE: Karma still fails due to some integration issues for test reporting. It does not
appear to be affecting the component integration.

capture467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant