Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat () update to stencil 0.16.1 and Angular 7 #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

peterennis
Copy link

This fixes the Stencil build #5
Some doc changes will be needed - later after PR review.

The integration to angular still needs to be done and I am working with A7+

fwt-slider

@peterennis
Copy link
Author

Fix for #7

@seveves
Copy link
Owner

seveves commented Dec 12, 2018

Do we need to update the documentation?
Are you going to update to Angular 7?

@peterennis
Copy link
Author

@seveves
I plan to update to A7 and already have some test/demo working here:
https://github.com/peterennis/aeicons/commit/13dbef9d34364dafdd0be8b65e197540a6d885cc
https://aeicons.adaept.com/
There are lots of changes in Stencil and Ionic is moving fast towards a RC for 4.0
Documentation should be updated eventually.

This has now been merged into Ionic: ionic-team/ionic-framework#16559
so the real value of your repo would be as an example of best practice for Angular integration,
i.e. improve the documentation.

How do you want to proceed?

@peterennis peterennis changed the title feat () update to stencil 0.15.2 feat () update to stencil 0.16.1 Dec 13, 2018
@peterennis peterennis changed the title feat () update to stencil 0.16.1 WIP: feat () update to stencil 0.16.1 Dec 13, 2018
@peterennis peterennis changed the title WIP: feat () update to stencil 0.16.1 WIP: feat () update to stencil 0.16.1 and Angular 7 Dec 13, 2018
@seveves
Copy link
Owner

seveves commented Dec 13, 2018

This repo was only to show how you can use StencilJS in combination with Angular. So if the documentation (README.md) is still suitable after your changes then I would merge your updates.

Just let me know when you are thinking that it is ready. I would test it and merge it afterwards then.

Thank you so far 👍

@peterennis
Copy link
Author

@seveves
Work completed in this ticket: #8
Ready for review.
I can then update this PR, or close it and make a clean one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants