add zoom in/out feature #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 12, 2018 19:13
|
I've also found another way to get the feature by implementing the code directy in the service. see my last commit. |
|
@re7w12u are you still interested in adding this feature? |
|
@hypery2k Yes, for sure ! Let me know if I can help |
|
if you like you can sent a PR to my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've been using your module (thanks btw ;) ) in an application and I wanted to leverage the Vis zoomIn zoomOut feature. This leads me to 2 questions :
I was able to make it work, but I had to change the node_modules/@types/vis/index.d.ts and add 2 new method signatures in the Timeline class (line 723). I can feel this is kind of wrong. I'm fairly new to this and I'm not sure about how to do it right. What would you suggest?
Once it's properly done, would you agree on merging my code?