Skip to content

Commit

Permalink
#cnsqa-1687 @typescript-eslint/no-empty-object-type next-line rule
Browse files Browse the repository at this point in the history
  • Loading branch information
lukasPan committed Oct 25, 2024
1 parent d5caae3 commit d9bbe97
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 2 deletions.
1 change: 0 additions & 1 deletion eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ module.exports = typescriptEslint.config(
'@typescript-eslint/consistent-type-exports': 'error',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/no-explicit-any': 'warn',
'@typescript-eslint/no-empty-object-type': 'off',
'@typescript-eslint/ban-ts-comment': [
'error',
{ 'ts-expect-error': false },
Expand Down
1 change: 1 addition & 0 deletions packages/plugin-analytic-fb-pixel/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export interface PluginAnalyticFBPixelSettings {
}

declare module '@ima/core' {
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
interface PluginAnalyticSettings extends PluginAnalyticFBPixelSettings {}

interface PluginSettings {
Expand Down
1 change: 1 addition & 0 deletions packages/plugin-analytic-google/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export interface PluginAnalyticGoogleSettings {
}

declare module '@ima/core' {
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
interface PluginAnalyticSettings extends PluginAnalyticGoogleSettings {}

interface PluginSettings {
Expand Down
1 change: 1 addition & 0 deletions packages/plugin-analytic/src/types.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type { Events } from './Events';

declare module '@ima/core' {
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
interface PluginAnalyticSettings {}

interface PluginSettings {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
//
import { UserAgent } from '@ima/plugin-useragent';
import { toMockedInstance } from 'to-mock';

Expand Down
1 change: 1 addition & 0 deletions packages/plugin-websocket/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export interface PluginWebsocketSettings {
}

declare module '@ima/core' {
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
interface PluginSettings extends PluginWebsocketSettings {}
interface Settings {
plugin: PluginSettings;
Expand Down

0 comments on commit d9bbe97

Please sign in to comment.