New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review #1

Open

mosdevly wants to merge 1 commit into master from feedback

mosdevly commented Oct 27, 2017

Not bad at all! You didn't get to implement a core feature, the vote, but you did a lot of good work on getting the API working.

See the comments in the code changes for more detail, but here's a summary:

Backend should handle all your data. That includes calls to
Frontend should interact with your backend to display data
DRY up the code! You have in a couple of places 3 functions where 1 will do.


          Code review

962383d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet