Cache openssl cert lookup and don't bail on error #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
force-pushed
the
fix-root-config
branch
2 times, most recently
from
05a3c0e to
00fc1f7
Compare
sfackler
force-pushed
the
fix-root-config
branch
from
00fc1f7 to
c5289c0
Compare
jtojnar
reviewed
Mar 26, 2025
| @@ -6,7 +6,7 @@ license = "MIT OR Apache-2.0" | |||
| description = "A wrapper over a platform's native TLS implementation" | |||
| repository = "https://github.com/sfackler/rust-native-tls" | |||
| readme = "README.md" | |||
| rust-version = "1.53.0" | |||
| rust-version = "1.80.0" | |||
There was a problem hiding this comment.
Is there a way to avoid bumping the minimal compiler version? 0.2.13 broke GStreamer Rust plug-ins but the stable branch is stuck on 1.71.
There was a problem hiding this comment.
Why is it stuck on 1.71?
There was a problem hiding this comment.
Reply from a GStreamer developer:
For the question on github: because various people consider updating the toolchain requirements a breaking change because it's apparently fine to update all kinds of software but not the toolchain. I don't agree with that but I don't have the energy to deal with these people.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the old behavior of only running the probe logic once, and not failing on invalid cert files or dirs.
Closes #320