-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SSL_group_to_name and SSL_get_negotiated_group #2201
Open
romen
wants to merge
7
commits into
sfackler:master
Choose a base branch
from
romen:nt/SSL_get_negotiated_group
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f79c037
Add support for SSL_group_to_name and SSL_get_negotiated_group
romen a988bdf
fixup! Add support for SSL_group_to_name and SSL_get_negotiated_group
romen 22c085c
fixup! Add support for SSL_group_to_name and SSL_get_negotiated_group
romen 0d838a5
fixup! Add support for SSL_group_to_name and SSL_get_negotiated_group
romen 3f4308f
fixup! Add support for SSL_group_to_name and SSL_get_negotiated_group
romen 893ce6a
Add a NegotiatedGroup wrapper struct
romen 70017d1
fixup! Add a NegotiatedGroup wrapper struct
romen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we shouldn't be exposing this as a raw c_int. Since their doing the weird unknown thing, I think we'd need to make a
NegotiatedGroup
type that provides apub fn nid(self) -> Option<Nid>
andpub fn unknown_group_id(self) -> Option<i32>
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do this change.
Then again in
SSL::group_to_name
which callsSSL_group_to_name()
, we need the raw unalteredc_int
.Should the
NegotiatedGroup
type implementFrom/To
trait to convert back to the rawc_int
?Suggestions on how to implement that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, these wrapper types have an
as_raw
method to get the c_int out: https://docs.rs/openssl/latest/openssl/nid/struct.Nid.html#method.as_rawThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried addressing this with 893ce6a