update definition of docker image #781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 7, 2021
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 7, 2021
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 7, 2021
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 7, 2021
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 7, 2021
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
replication-image
branch
from
9bbe21c to
80763ff
Compare
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 7, 2021
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 7, 2021
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 8, 2021
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 11, 2021
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 15, 2021
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 15, 2021
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
replication-image
branch
from
80763ff to
c58b726
Compare
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 15, 2021
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
added a commit
to petrosagg/rust-postgres
that referenced
this pull request
Jun 15, 2021
Signed-off-by: Petros Angelatos <[email protected]>
|
I've updated the build setup so we don't need to build and publish the image at all - it now just volume mounts the config script directly into the base postgres container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile in the repo is currently unbuildable because the upstream images now require passing a
POSTGRES_PASSWORDenvironment variable explicitly.This PR supplies the environment variable and also allows replication connections. Once the updated image is published we'll also have meaningful CI results in #778