mod_dent request tc 'pref 1' only on ingress

sflow · Mar 24, 2021 · c684822 · c684822
1 parent fe456f4
commit c684822
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/Linux/mod_dent.c b/src/Linux/mod_dent.c
@@ -172,11 +172,13 @@ extern "C" {
     strArrayAdd(cmdline, "dev");
     strArrayAdd(cmdline, adaptor->deviceName);
     strArrayAdd(cmdline, egress ? "egress" : "ingress");
-    // Sampling should happen before ingress ACLs, so ask for preference/priority 1.
-    // For egress the ACLs have already been applied, but it still seems more stable
-    // and consistent to request pref 1.
-    strArrayAdd(cmdline, "pref");
-    strArrayAdd(cmdline, "1");
+    if(!egress) {
+      // On ingress, sampling should happen before ACLs, so ask for preference/priority 1.
+      // (On egress any ACLs should apply first, so allow the sampling step to be added
+      // in the default manner at the end of the chain).
+      strArrayAdd(cmdline, "pref");
+      strArrayAdd(cmdline, "1");
+    }
     strArrayAdd(cmdline, "matchall");
     if(sp->dent.sw == NO)
       strArrayAdd(cmdline, "skip_sw");