-
Notifications
You must be signed in to change notification settings - Fork 42
deepep prefill support a2 #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @zuje123, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the DeepEP framework by integrating prefill support and optimizing for the Ascend910B (A2) architecture. It introduces a modular kernel build system, dynamically configures compilation based on the target platform, and implements advanced inter-node communication mechanisms for distributed MoE operations. These changes aim to improve the efficiency and specialized handling of data dispatch and combination in a distributed AI computing environment, leveraging the unique capabilities of the A2 platform. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the 'a2' architecture, primarily by introducing a new set of operations in csrc/deepep/ops2 and updating the build scripts and C++ source files to handle this new architecture. While the changes are extensive and seem to correctly add the new functionality, there are several areas for improvement regarding code duplication, readability, and potential bugs that should be addressed.
build for deepep a2 package