-
Notifications
You must be signed in to change notification settings - Fork 43
support small bs = 1 or 2 #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @wangyibo1005, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the system's ability to handle and test very small batch sizes, specifically batch size 1. It includes a modification to a core padding constant in the C++ implementation and introduces a new Python test flag and associated logic to validate the behavior of fused deep MoE operations under these specific, low-batch conditions. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to add support for small batch sizes (1 or 2) by reducing the padding size in the C++ code and adding a test flag for small batch sizes in the Python test. The change in deep_ep.cpp seems correct for this purpose. In the Python test file, I've suggested several improvements related to Python's PEP-8 naming conventions and code clarity. These changes will improve the readability and maintainability of the test code.
No description provided.