-
Notifications
You must be signed in to change notification settings - Fork 46
add mla_preprocess test script #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mla_preprocess test script #153
Conversation
LinyuanLi0046
commented
Oct 29, 2025
- golden test for mla_preprocess
- include bf16 and fp16 dtype, with cachemode krope_ctkv, int8_nzcache and nzcache
- support two types of golden: unfused NPU small ops and Pytorch native
Summary of ChangesHello @LinyuanLi0046, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new, comprehensive test script for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a comprehensive set of golden tests for the mla_preprocess operator, covering various data types and cache modes. The tests are well-structured. My review focuses on improving test correctness and code quality. I've identified a couple of high-severity issues: one where tests use print statements instead of assertions, which could lead to silent failures, and another where a test case uses an incorrect data type. I have also included several medium-severity suggestions to clean up unused code and improve overall quality.