Skip to content

Conversation

@LinyuanLi0046
Copy link
Contributor

  • golden test for mla_preprocess
  • include bf16 and fp16 dtype, with cachemode krope_ctkv, int8_nzcache and nzcache
  • support two types of golden: unfused NPU small ops and Pytorch native

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @LinyuanLi0046, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new, comprehensive test script for the mla_preprocess operation. The script is designed to validate the correctness of mla_preprocess across various configurations, including different data types (bfloat16, float16) and cache modes (krope_ctkv, int8_nzcache, nzcache). It employs two distinct golden reference implementations—one using NPU-specific operations and another using standard PyTorch—to ensure robust verification of the operator's behavior.

Highlights

  • New Test Script: A new test script, test_mla_preprocess.py, has been added to provide comprehensive validation for the mla_preprocess operation.
  • Comprehensive Data Type and Cache Mode Coverage: The tests cover bfloat16 and float16 data types, and include various cache modes such as krope_ctkv, int8_nzcache, and nzcache.
  • Dual Golden Reference Implementations: The script supports two types of golden references: one based on unfused NPU small operations (golden1_torch_npu) and another on native PyTorch operations (golden2_pytorch), ensuring robust verification.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive set of golden tests for the mla_preprocess operator, covering various data types and cache modes. The tests are well-structured. My review focuses on improving test correctness and code quality. I've identified a couple of high-severity issues: one where tests use print statements instead of assertions, which could lead to silent failures, and another where a test case uses an incorrect data type. I have also included several medium-severity suggestions to clean up unused code and improve overall quality.

RuixuanZhang06
RuixuanZhang06 previously approved these changes Nov 3, 2025
@RuixuanZhang06 RuixuanZhang06 merged commit 65dbcc2 into sgl-project:main Nov 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants