Don't add custom fields before controller #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fields are added when an exception is thrown
|
Fix for issue #114 |
| payload[:status] = response.status | ||
| result | ||
| ensure | ||
| if self.respond_to?(:logtasher_add_custom_fields_to_payload) |
There was a problem hiding this comment.
i think it should be :logstasher_add_custom_fields_to_payload instead of :logtasher_add_custom_fields_to_payload
| @@ -65,5 +65,44 @@ def subject.index(*args) | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| context "payload has custom fields defined" do | |||
| before :each do | |||
There was a problem hiding this comment.
:each part is redundant. before { some_code } is same as before(:each) { some_code }. This also applies to after blocks
shadabahmed
force-pushed
the
master
branch
2 times, most recently
from
d37188e to
9480e28
Compare
shadabahmed
force-pushed
the
main
branch
4 times, most recently
from
aa5da57 to
f28e910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure custom fields are added when an exception is thrown from the controller