-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tailwind.config.ts #1247
Support tailwind.config.ts #1247
Conversation
@lukahartwig is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I hope for this PR to be merged.
No updates on this yet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it. Thank you!
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
We need a changeset here. I'll add one. |
Fixes shadcn-ui#659 Fixes shadcn-ui#633 Create Next App is using `tailwind.config.ts` in the TypeScript template. Since this is a very common use case it would be nice to preserve the type safety of the file. I added new templates for TypeScript files. I see there is an issue shadcn-ui#1073 which asks for ESM support as well. This is not included in this PR. I also fixed the type error in the keyframes that is also handled in shadcn-ui#636
Fixes shadcn-ui#659 Fixes shadcn-ui#633 Create Next App is using `tailwind.config.ts` in the TypeScript template. Since this is a very common use case it would be nice to preserve the type safety of the file. I added new templates for TypeScript files. I see there is an issue shadcn-ui#1073 which asks for ESM support as well. This is not included in this PR. I also fixed the type error in the keyframes that is also handled in shadcn-ui#636
Fixes #659
Fixes #633
Create Next App is using
tailwind.config.ts
in the TypeScript template. Since this is a very common use case it would be nice to preserve the type safety of the file.I added new templates for TypeScript files. I see there is an issue #1073 which asks for ESM support as well. This is not included in this PR.
I also fixed the type error in the keyframes that is also handled in #636