Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): avoids overflow #1345

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

soymartinez
Copy link

Fixes #416

This PR avoids the overflow of the whole window when the button is not in the viewport and the content has some absolute position.


The problem starts with the sr-only property of the span tag inside the Button component which is the Trigger of the DropdownMenu.

image

By setting the relative position in the Button component we limit the content of any absolute position and in this way it is not necessary to limit the whole table or any parent tag.


Related issues

@vercel
Copy link

vercel bot commented Aug 25, 2023

@omgismartinez is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants