fix: enable input editing in the dialog demo #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yportfolio is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lloydrichards
pushed a commit
to lloydrichards/shadcn-ui
that referenced
this pull request
Oct 3, 2023
Co-authored-by: shadcn <[email protected]>
kjxbyz
pushed a commit
to muse-ui/muse-ui
that referenced
this pull request
Jun 7, 2024
Co-authored-by: shadcn <[email protected]>
artabr
pushed a commit
to artabr/shadcn-ui
that referenced
this pull request
Dec 15, 2024
Co-authored-by: shadcn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dialog demo displays a warning message in development mode, as shown in the following.
"Warning: You provided a
valueprop to a form field without anonChangehandler. This will render a read-only field. If the field should be mutable usedefaultValue. Otherwise, set eitheronChangeorreadOnly."Additionally, it renders the input fields "name" and "username" uneditable. This PR aims to address the warning and make these inputs editable.