Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: identical interface and function name #1438

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

wobsoriano
Copy link
Contributor

VSCode is shouting at me for this identical interface and function name:

Screenshot 2023-09-03 at 7 48 09 PM

This PR just renames the interface to a more sensible one.

@vercel
Copy link

vercel bot commented Sep 4, 2023

@wobsoriano is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@wobsoriano wobsoriano changed the title fix: rename already declared interface fix: rename already declared interface name Sep 4, 2023
@wobsoriano wobsoriano changed the title fix: rename already declared interface name fix: identical interface and function name Sep 4, 2023
@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 0:30am

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@shadcn shadcn merged commit 7ce6c49 into shadcn-ui:main Sep 18, 2023
5 checks passed
lloydrichards pushed a commit to lloydrichards/shadcn-ui that referenced this pull request Oct 3, 2023
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants