Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(www): add bun support for installation commands #1445

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

rgodha24
Copy link
Contributor

@rgodha24 rgodha24 commented Sep 4, 2023

The title basically says it all

adding a component:
copying a command with npm, yarn, pnpm, bun as options

creating an app:
create-next-app with npm, yarn, pnpm, bun

initing shadcn-ui:
shadcn-ui init with npm, yarn, pnpm, bun

@vercel
Copy link

vercel bot commented Sep 4, 2023

@rgodha24 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@ParthJadhav
Copy link

I can back this change ! Worth adding 🤝

@rafaelsilva81
Copy link

Oh, I started doing this because I saw #1480 but great to see someone already did it

This is a good change!

@rgodha24
Copy link
Contributor Author

It's honestly probably my bad - I forgot to make an issue before the pr. It would be great if we can get this merged though :)

@rgodha24 rgodha24 changed the title feat(www): add bun support for commands feat(www): add bun support for installation commands Sep 12, 2023
@jocarrd
Copy link

jocarrd commented Sep 12, 2023

I love bun and I believe it's good to provide support in the documentation

@rgodha24
Copy link
Contributor Author

rgodha24 commented Sep 21, 2023

@shadcn can you review this pr whenever you get the chance? It's a tiny pr and it would be great to get merged.

@vercel
Copy link

vercel bot commented Sep 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Sep 21, 2023 3:16am

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shadcn shadcn merged commit 4f8d768 into shadcn-ui:main Sep 21, 2023
4 checks passed
lloydrichards pushed a commit to lloydrichards/shadcn-ui that referenced this pull request Oct 3, 2023
* feat(www): add bun support for commands

* chore: remove changeset

---------

Co-authored-by: shadcn <[email protected]>
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
* feat(www): add bun support for commands

* chore: remove changeset

---------

Co-authored-by: shadcn <[email protected]>
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
* feat(www): add bun support for commands

* chore: remove changeset

---------

Co-authored-by: shadcn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants