Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dark-mode): add missing prop to ThemeProvider #1447

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

RahimGuerfi
Copy link
Contributor

The ThemeProvider is missing disableTransitionOnChange prop. Adding this prop ensures your UI to stay consistent when changing the theme.

The ThemeProvider is missing disableTransitionOnChange prop.
Adding this prop ensures your UI to stay consistent when changing the theme.
@vercel
Copy link

vercel bot commented Sep 5, 2023

@RahimGuerfi is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I've been meaning to add this. Thank you.

@shadcn shadcn added documentation Improvements or additions to documentation area: www labels Sep 7, 2023
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 0:37am

@shadcn shadcn merged commit b838ffe into shadcn-ui:main Sep 18, 2023
lloydrichards pushed a commit to lloydrichards/shadcn-ui that referenced this pull request Oct 3, 2023
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: www documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants