fix(www): Unnecessary AlertDialogPortal and DialogPortal component removed #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iam-rohid is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
Hmmm it looks like this was removed but released as a patch in radix-ui/primitives#2178 I'll review and merge. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shadcn
added
bug
|
Thanks for merging 😀 |
This was referenced Oct 10, 2023
Closed
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 21, 2023
Fixes #1595, #1644 This PR changes the components that use the `DialogPortal` element to be aliases rather than components that pass a className prop. The `DialogPortalProps` type from `@radix/react-dialog` recently had a patch update that probably should have been a minor or maybe a major update which is causing a few people to see the error `Property 'className' does not exist on type 'DialogPortalProps'`. Since the `DialogPortal` component doesn't actually output any DOM elements, it never technically supported the `className` prop and the fact that it surfaced that prop was really a bug. The `AlertDialog` and `Dialog` components were updated in #1603, but the `Sheet` component still references `className` which is resolved in this PR.
kjxbyz
pushed a commit
to muse-ui/muse-ui
that referenced
this pull request
Jun 7, 2024
kjxbyz
pushed a commit
to muse-ui/muse-ui
that referenced
this pull request
Jun 7, 2024
Fixes shadcn-ui#1595, shadcn-ui#1644 This PR changes the components that use the `DialogPortal` element to be aliases rather than components that pass a className prop. The `DialogPortalProps` type from `@radix/react-dialog` recently had a patch update that probably should have been a minor or maybe a major update which is causing a few people to see the error `Property 'className' does not exist on type 'DialogPortalProps'`. Since the `DialogPortal` component doesn't actually output any DOM elements, it never technically supported the `className` prop and the fact that it surfaced that prop was really a bug. The `AlertDialog` and `Dialog` components were updated in shadcn-ui#1603, but the `Sheet` component still references `className` which is resolved in this PR.
artabr
pushed a commit
to artabr/shadcn-ui
that referenced
this pull request
Dec 15, 2024
artabr
pushed a commit
to artabr/shadcn-ui
that referenced
this pull request
Dec 15, 2024
Fixes shadcn-ui#1595, shadcn-ui#1644 This PR changes the components that use the `DialogPortal` element to be aliases rather than components that pass a className prop. The `DialogPortalProps` type from `@radix/react-dialog` recently had a patch update that probably should have been a minor or maybe a major update which is causing a few people to see the error `Property 'className' does not exist on type 'DialogPortalProps'`. Since the `DialogPortal` component doesn't actually output any DOM elements, it never technically supported the `className` prop and the fact that it surfaced that prop was really a bug. The `AlertDialog` and `Dialog` components were updated in shadcn-ui#1603, but the `Sheet` component still references `className` which is resolved in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are unnecessary
AlertDialogPortalandDialogPortalcomponents inalert-dialoganddialog. And they are accepting className props which is not required inAlertDialogPortalandDialogPortalcomponent from radix-ui. So, I have removed them.