-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL Support #1638
Open
nahasco
wants to merge
29
commits into
shadcn-ui:main
Choose a base branch
from
nahasco:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+244
−174
Open
RTL Support #1638
Changes from 17 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
17c6690
feat(alert-dialog): add rtl support
nahasco c83be56
feat(alert): add rtl support
nahasco a25fa15
feat(carousel): add rtl support
nahasco cbe3c2c
feat(command): add rtl support
nahasco 3233e39
feat(context-menu): add rtl support
nahasco 527da48
feat(dialog): add rtl support
nahasco 401a470
feat(drawer): add rtl support
nahasco 6ae9bee
feat(dropdown-menu): add rtl support
nahasco de6fe31
feat(menubar): add rtl support
nahasco e8cfcaf
feat(navigation-menu): add rtl support
nahasco ef74963
feat(pagination): add rtl support
nahasco 48a1122
refactor: use tailwind rtl and rotate to rotate chevrons instead of u…
nahasco f8aef7f
feat(carousel): improve rtl support
nahasco 6d2a66e
feat(select): add rtl support
nahasco 8550e65
feat(sheet): add rtl support
nahasco f18ccc1
feat(switch): add rtl support
nahasco a441163
feat(table): add rtl support
nahasco d3ba573
feat(breadcrumb): add rtl support
jjeem 14ba98c
feat(input-otp): add rtl support
jjeem 8525300
feat(calendar): add rtl support
jjeem 3a5b777
feat(toast): add rtl support
nahasco 238d856
Merge pull request #1 from jjeem/main
nahasco 0d46f0d
Sync fork
nahasco b159f6e
feat(sidebar): add rtl support
jjeem 370b30d
Merge branch 'main' into main
nahasco 844f09a
Merge branch 'nahasco:main' into main
jjeem a1b28d9
Merge pull request #2 from jjeem/main
nahasco 1f32bc2
Merge branch 'main' into main
nahasco 11485d0
Merge branch 'main' into main
nahasco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
flex flex-col-reverse sm:flex-row sm:justify-end sm:gap-2
? I think it'd be cleaner.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didnt want to change the original styling alot. Just adding rtl:space-x-reverse at the end is the most minimal, i think.