-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(install): Clarify & Match tsconfig Edits #1642
Merged
kodiakhq
merged 2 commits into
shadcn-ui:main
from
CamTheGoblin:docs/fix-vite-install-path-setup
Oct 19, 2023
Merged
docs(install): Clarify & Match tsconfig Edits #1642
kodiakhq
merged 2 commits into
shadcn-ui:main
from
CamTheGoblin:docs/fix-vite-install-path-setup
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Cam-Bread is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
SoyDiego
approved these changes
Oct 1, 2023
shadcn
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Thank you.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shadcn
added
documentation
Improvements or additions to documentation
area: www
automerge
labels
Oct 19, 2023
kjxbyz
pushed a commit
to muse-ui/muse-ui
that referenced
this pull request
Jun 7, 2024
This is a small update to the installation instructions for some of the frameworks to make the instructions on editing the tsconfig file consistant across the frameworks, and remove some potentially confusing wording (if people read too fast...like me). Mainly applying the gatsby tsconfig instructions to vite and astro, as it is the most clear. Additionally changed the wording from: ``` Add the code below to the compilerOptions... ``` to: ``` Add the following code to the compilerOptions... ``` to avoid people easily misreading it as "add the code **below the** compilerOptions".
artabr
pushed a commit
to artabr/shadcn-ui
that referenced
this pull request
Dec 15, 2024
This is a small update to the installation instructions for some of the frameworks to make the instructions on editing the tsconfig file consistant across the frameworks, and remove some potentially confusing wording (if people read too fast...like me). Mainly applying the gatsby tsconfig instructions to vite and astro, as it is the most clear. Additionally changed the wording from: ``` Add the code below to the compilerOptions... ``` to: ``` Add the following code to the compilerOptions... ``` to avoid people easily misreading it as "add the code **below the** compilerOptions".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small update to the installation instructions for some of the frameworks to make the instructions on editing the tsconfig file consistant across the frameworks, and remove some potentially confusing wording (if people read too fast...like me).
Mainly applying the gatsby tsconfig instructions to vite and astro, as it is the most clear.
Additionally changed the wording from:
to:
to avoid people easily misreading it as "add the code below the compilerOptions".