Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(install): Clarify & Match tsconfig Edits #1642

Merged

Conversation

CamTheGoblin
Copy link
Contributor

This is a small update to the installation instructions for some of the frameworks to make the instructions on editing the tsconfig file consistant across the frameworks, and remove some potentially confusing wording (if people read too fast...like me).

Mainly applying the gatsby tsconfig instructions to vite and astro, as it is the most clear.
Additionally changed the wording from:

 Add the code below to the compilerOptions...

to:

Add the following code to the compilerOptions...

to avoid people easily misreading it as "add the code below the compilerOptions".

@vercel
Copy link

vercel bot commented Oct 1, 2023

@Cam-Bread is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you.

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 5:24pm

@shadcn shadcn added documentation Improvements or additions to documentation area: www automerge labels Oct 19, 2023
@kodiakhq kodiakhq bot merged commit 9091dcd into shadcn-ui:main Oct 19, 2023
6 checks passed
shadcn added a commit that referenced this pull request Oct 19, 2023
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
This is a small update to the installation instructions for some of the frameworks to make the instructions on editing the tsconfig file consistant across the frameworks, and remove some potentially confusing wording (if people read too fast...like me). 

Mainly applying the gatsby tsconfig instructions to vite and astro, as it is the most clear. 
Additionally changed the wording from:
```
 Add the code below to the compilerOptions...
```
to:
```
Add the following code to the compilerOptions...
```
to avoid people easily misreading it as "add the code **below the** compilerOptions".
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
This is a small update to the installation instructions for some of the frameworks to make the instructions on editing the tsconfig file consistant across the frameworks, and remove some potentially confusing wording (if people read too fast...like me). 

Mainly applying the gatsby tsconfig instructions to vite and astro, as it is the most clear. 
Additionally changed the wording from:
```
 Add the code below to the compilerOptions...
```
to:
```
Add the following code to the compilerOptions...
```
to avoid people easily misreading it as "add the code **below the** compilerOptions".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: www automerge documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants