Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes redundant class-name from H2 component #1703

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

dev-shetty
Copy link
Contributor

The class transition-colors need not be in the h2 element.
If the user wants they can add it externally, currently it is not used because there is no hover or focus effect declared.

This PR removes it from both default and new-york styles

@vercel
Copy link

vercel bot commented Oct 8, 2023

@deveesh-shetty is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Thank you.

@shadcn shadcn merged commit 14abbd9 into shadcn-ui:main Oct 18, 2023
4 checks passed
@dev-shetty
Copy link
Contributor Author

@shadcn if possible can you put hacktoberfest labels for PR?

kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
…#1703)

* chore: removes redundant class from typography-h2

* chore: remove class from new york style

---------

Co-authored-by: shadcn <[email protected]>
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
…#1703)

* chore: removes redundant class from typography-h2

* chore: remove class from new york style

---------

Co-authored-by: shadcn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants