feat(select): update select component to include radix primitives for scrolling on large datasets. #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to default ui
This reverts commit b37fc17.
|
@iaingymware is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
Merged latest main into PR branch as was outdated. |
shadcn
reviewed
Oct 16, 2023
|
@shadcn awaiting review. |
shadcn
added
the
area: roadmap
|
Updated branch as outdated. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Is this PR now complete? I don't see that it has been reviewed yet. Is there any action pending on me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an up and down chevron to the select content area for when too many select items exist to display within the viewport. This is taking the radix ScrollUpButton and ScollDownButtons from https://www.radix-ui.com/primitives/docs/components/select
As can be seen, the chevrons will only appear when a large number of SelectItems exist.
I noticed updating the registry added like 80 files to the PR so I removed it (the 3rd and 4th commit). I am therefore just updating two files, the default and newyork select components.
If the registry update is required, happy to receive direction on how best to do this.
Thanks