Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): appearance form #1804

Closed
wants to merge 3 commits into from
Closed

fix(example): appearance form #1804

wants to merge 3 commits into from

Conversation

jolbol1
Copy link

@jolbol1 jolbol1 commented Oct 23, 2023

The appearance form in the example has some bugs.

Firstly, if you dont touch the select component and try to submit, it will error and tell you that you need to select a font, despite inter being shown as default.
image

Next, it is not using a shadcn select box. Instead its just a html one. I have switched this out.
image

@vercel
Copy link

vercel bot commented Oct 23, 2023

@jolbol1 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 6:45am

@shadcn
Copy link
Collaborator

shadcn commented Nov 12, 2023

@jolbol1 Thanks for the fix. Let's fix the validation one in this PR. I'm working on a native select component.

@shadcn shadcn added bug Something isn't working area: examples postpone: more info or changes requested maintainers asked a question or needs more info labels Nov 12, 2023
@jolbol1 jolbol1 closed this by deleting the head repository Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples bug Something isn't working postpone: more info or changes requested maintainers asked a question or needs more info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants