-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multi-select component #2773
base: main
Are you sure you want to change the base?
Conversation
@yeliex is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
7551f36
to
12893f8
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Wow. This is really well done. Love the composable API. Adding it to the roadmap. |
Great work. One piece of feedback, I am unable to tab to the component in my app and in the preview docs. |
Hey, when is this released? @shadcn We want to use it in our project. |
you can just add raw file to your project and edit it as your like, it matches this library's like. currently i has no free time to add tab support and there still has other options for maintainer |
2024-05-07.10-44-22.mp4CommandList should be there instead of CommandGroup. |
badges can be delete when disabled is this intended? |
Awesome work!! |
This looks amazing! I've got a few suggestions:
|
When will this PR be merged @shadcn? |
@shadcn Any updates please? a lot of developer are waiting for this.. |
This PR created another multi-select component following the radix and shadcn-ui design pattern.
Why another component compare to #1616 :
Currently I alternative this with the
Command
component for reusing styles, it may takes better performance and user experience if we can remove it in the future, and alternativetag mode
(input directly in trigger like antd)This component alternative has been used in my company's production for 2 months and works well with about 20 pages. Now we feedback to the community, hope it helps