Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion): remove invalid collapsible prop #496

Merged
merged 2 commits into from
Oct 21, 2023
Merged

fix(accordion): remove invalid collapsible prop #496

merged 2 commits into from
Oct 21, 2023

Conversation

kevinmitch14
Copy link
Contributor

collapsible is not a valid prop when <Accordion type="mutliple" />.

this prop is only valid when type="single"

From docs: collapsible - When type is "single", allows closing content when clicking trigger for an open item.

only available when type="single"
@vercel
Copy link

vercel bot commented May 30, 2023

@kevinmitch14 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@kevinmitch14 kevinmitch14 changed the title fix: remove invalid accordion prop fix(accordion): remove invalid collapsible prop May 30, 2023
Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shadcn shadcn added documentation Improvements or additions to documentation area: www automerge labels Oct 21, 2023
@vercel
Copy link

vercel bot commented Oct 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2023 0:27am

@shadcn shadcn merged commit b8810ca into shadcn-ui:main Oct 21, 2023
5 checks passed
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
only available when type="single"

Co-authored-by: shadcn <[email protected]>
u007 pushed a commit to u007/ui that referenced this pull request Sep 1, 2024
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
only available when type="single"

Co-authored-by: shadcn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: www automerge documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants