fix(select): Constrain the height of SelectContent to not exceed the viewport #6059
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@webkonstantin is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
webkonstantin
force-pushed
the
fix-select-content-max-height
branch
from
d0f113d to
b2354db
Compare
webkonstantin
changed the title
webkonstantin
force-pushed
the
fix-select-content-max-height
branch
from
b2354db to
6007a91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
--radix-select-trigger-heightseems to be a mistake here,--radix-select-content-available-heightshould be used insteadSee https://www.radix-ui.com/primitives/docs/components/select#constrain-the-content-size
Also see before and after