Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Font instructions when adding to an existing project #69

Closed
wants to merge 3 commits into from

Conversation

niclas-j
Copy link

@niclas-j niclas-j commented Feb 8, 2023

See #68

@vercel
Copy link

vercel bot commented Feb 8, 2023

@niclas-j is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Feb 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
next-template ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 5:25PM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 5:25PM (UTC)

@mozzius
Copy link

mozzius commented Mar 7, 2023

As of Next.js 13.2, @next/font has been integrated into the core next package (see here), so no need to install an extra package.

Also, it would be nice to also provide instructions for non-Next usage!
You can do it purely in globals.scss as so:

@import url("https://fonts.googleapis.com/css2?family=Inter:wght@400;600;700&display=swap");

@tailwind base;
@tailwind components;
@tailwind utilities;

:root {
  --font-sans: "Inter";
}

@shadcn
Copy link
Collaborator

shadcn commented Oct 15, 2023

@niclas-j Thanks for looking into this. I created an updated PR with docs for adding fonts. #1752

Marking this one as done. Feel free to reopen if not.

Thank you.

@shadcn shadcn closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants