Add datalayout for constant buffers. #5608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
force-pushed
the
spirv
branch
2 times, most recently
from
552e00a to
8d64ce3
Compare
cheneym2
reviewed
Nov 21, 2024
cheneym2
reviewed
Nov 21, 2024
cheneym2
reviewed
Nov 21, 2024
cheneym2
reviewed
Nov 21, 2024
cheneym2
reviewed
Nov 21, 2024
Sorry if I'm misunderstanding, but I can't tell that the test changes are using the option to specify buffer layouts like in this commit description. |
|
Looks good, but AFAICT a test for the feature to add a type to the ConstantBuffer declaration is not here. |
|
|
cheneym2
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5598.
Closes #5595.
This PR adds support for specifying data layout for constant buffers, and fixes the default layout of push constant buffer to be std430.
ConstantBuffer can now be specified with a buffer layout, similar to StructuredBuffer:
Also fixes a bug that incorrectly causes specialization constants to occupy space 0.