Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support interpolation modifiers for WGSL #5641

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

aleino-nv
Copy link
Collaborator

  • Move interpolation decorations to flattened structs during legalization
  • Add some code to emit interpolate attributes
  • Enable 'nointerpolate' test

#5625

@aleino-nv aleino-nv requested a review from a team as a code owner November 22, 2024 09:04
@aleino-nv aleino-nv added the pr: non-breaking PRs without breaking changes label Nov 22, 2024
@aleino-nv
Copy link
Collaborator Author

/format

@slangbot
Copy link
Contributor

🌈 Formatted, please merge the changes from this PR

aleino-nv added a commit to aleino-nv/slang that referenced this pull request Nov 22, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2024

CLA assistant check
All committers have signed the CLA.

@aleino-nv aleino-nv force-pushed the aleino/nointerpolate branch 3 times, most recently from c508b58 to 770a332 Compare November 22, 2024 09:27
Copy link
Collaborator

@csyonghe csyonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think it is more robust and correct to just transfer all decorations over.

source/slang/slang-ir-wgsl-legalize.cpp Outdated Show resolved Hide resolved
csyonghe
csyonghe previously approved these changes Nov 22, 2024
* Move struct key decorations to flattened structs.
** This includes interpolation mode decorations, which must be in the flattened struct.
* Emit interpolation attribute.
* Enable tests/render/nointerpolation.hlsl for WGSL, as a result.

This closes shader-slang#5625.
@aleino-nv aleino-nv merged commit d282701 into shader-slang:master Nov 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants