-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support interpolation modifiers for WGSL #5641
Merged
aleino-nv
merged 3 commits into
shader-slang:master
from
aleino-nv:aleino/nointerpolate
Nov 25, 2024
Merged
Support interpolation modifiers for WGSL #5641
aleino-nv
merged 3 commits into
shader-slang:master
from
aleino-nv:aleino/nointerpolate
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/format |
🌈 Formatted, please merge the changes from this PR |
aleino-nv
added a commit
to aleino-nv/slang
that referenced
this pull request
Nov 22, 2024
Format code for PR shader-slang#5641
c508b58
to
770a332
Compare
csyonghe
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I think it is more robust and correct to just transfer all decorations over.
csyonghe
previously approved these changes
Nov 22, 2024
jkwak-work
reviewed
Nov 23, 2024
* Move struct key decorations to flattened structs. ** This includes interpolation mode decorations, which must be in the flattened struct. * Emit interpolation attribute. * Enable tests/render/nointerpolation.hlsl for WGSL, as a result. This closes shader-slang#5625.
770a332
to
22f8d2d
Compare
This was referenced Nov 25, 2024
Closed
expipiplus1
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5625