Add missing WGSL intrinsics to test #5663
Open
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expipiplus1
force-pushed
the
push-zolpotxztyqz
branch
from
64db7e8
to
c63b3f8
Compare
aleino-nv
approved these changes
Nov 25, 2024
jkwak-work
requested changes
Nov 26, 2024
| @@ -1,7 +1,6 @@ | |||
| //TEST(compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj -output-using-type | |||
| //TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -shaderobj -output-using-type | |||
| // slang-test/WGPU: IR opcode during code emit #5263 | |||
| //DISABLE_TEST(compute):COMPARE_COMPUTE_EX:-wgpu | |||
| //TEST(compute):COMPARE_COMPUTE_EX:-wgpu | |||
There was a problem hiding this comment.
I think this line should be removed.
The line#2 will synthesize one for wgpu.
If we want to explicitly have one for wgpu, it will have to be more like
//TEST(compute):COMPARE_COMPUTE_EX:-wgpu -compute -shaderobj -output-using-type
There was a problem hiding this comment.
BTW, CI is failing for this reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5263