Move c++ parsing code from slang-cpp-extractor to static library #5675
+77
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
|
@expipiplus1 can you please take a look? |
aleino-nv
reviewed
Nov 26, 2024
aleino-nv
reviewed
Nov 26, 2024
jkwak-work
reviewed
Nov 27, 2024
Comment on lines
+17
to
+22
| #include "../tools/slang-cpp-parser/diagnostics.h" | ||
| #include "../tools/slang-cpp-parser/file-util.h" | ||
| #include "../tools/slang-cpp-parser/node.h" | ||
| #include "../tools/slang-cpp-parser/options.h" | ||
| #include "../tools/slang-cpp-parser/parser.h" | ||
| #include "../tools/slang-cpp-parser/unit-test.h" |
There was a problem hiding this comment.
Can we avoid using "../" here?
We already have a few but we should try to remove them not adding them.
|
This was discussed in #5565. My bad for not including it, I updated the PR description. It allows us to reuse the C++ parser code for generating C (and other) language bindings by parsing I didn't see any harm in renaming parts of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #5565, this is the initial work on extracting c++ parsing code from
slang-cpp-extractorto a separate static library. This will allow me to reuse the parser for my work on the language bindings generator. The currentslang-cpp-extractorand newly createdslang-cpp-parsercan still use some refactoring but I feel like that is better left for future PRs once I know how much additional code can be shared with the binding generator.Please ensure especially my changes to the CMake file look good, I'm not too familiar with it.