wgsl: signedness mismatch fixes #5692
Open
+49
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
added a commit
to aleino-nv/slang
that referenced
this pull request
Nov 27, 2024
…ss-mismatch-fixes Format code for PR shader-slang#5692
This fixes signedness mismatch issues for: - Binary operators - Return values This closes shader-slang#5606.
aleino-nv
force-pushed
the
aleino/wgsl-signedness-mismatch-fixes
branch
from
a68ec83
to
3b439d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some missing integer type conversions to legalize WGSL code.
I believe the issues fixed here are typically handled by implicit conversions in less strict languages.
WGSL, however, requires us to emit explicit casts in these cases.
This closes #5606