Feature/initialize list side branch #6058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizhangNV
requested review from
tangent-vector,
csyonghe,
expipiplus1 and
a team
as code owners
kaizhangNV
removed request for
a team,
expipiplus1,
csyonghe and
tangent-vector
kaizhangNV
force-pushed
the
feature/initialize-list-side-branch
branch
12 times, most recently
from
282ad96 to
8be343e
Compare
kaizhangNV
force-pushed
the
feature/initialize-list-side-branch
branch
6 times, most recently
from
2f3c992 to
7c5a8e8
Compare
Do not implicit initialize a struct that doesn't have explicit default constructor.
kaizhangNV
force-pushed
the
feature/initialize-list-side-branch
branch
from
2f2b61c to
7a5a914
Compare
kaizhangNV
added a commit
to kaizhangNV/slang
that referenced
this pull request
Feb 5, 2025
This is a follow-up to PR shader-slang#6058, where we switched to Falcor-new now we will switch back to Falcor.
Merged
csyonghe
pushed a commit
that referenced
this pull request
Feb 5, 2025
This is a follow-up to PR #6058, where we switched to Falcor-new now we will switch back to Falcor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.