Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow requiring glsl language extensions on structs #6173

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Allow requiring glsl language extensions on structs #6173

merged 4 commits into from
Jan 28, 2025

Conversation

expipiplus1
Copy link
Collaborator

No description provided.

@expipiplus1 expipiplus1 requested a review from a team as a code owner January 24, 2025 11:59
csyonghe
csyonghe previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@csyonghe csyonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Needs formatting and label.

@jkwak-work
Copy link
Collaborator

/format

@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Jan 25, 2025
@slangbot
Copy link
Contributor

🌈 Formatted, please merge the changes from this PR

@slangbot slangbot mentioned this pull request Jan 25, 2025
Merged
@expipiplus1 expipiplus1 mentioned this pull request Jan 28, 2025
Closed
@csyonghe csyonghe merged commit c356d3a into shader-slang:master Jan 28, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csyonghe csyonghe csyonghe approved these changes

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@expipiplus1 @jkwak-work @slangbot @csyonghe