Add Slang-specific intrinsics for integer pack/unpack #6459
Conversation
fairywreath
changed the title
|
According to the proposal, we should just delete int8_t4_packed as a special builtin basic type, and just define it as a typealias to uint. I now think it wasn’t not a great idea to introduce the type as another basic type, because it will introduce too many additional overloaded functions/operators for no benefit. Let’s remove it from our existing code. |
|
I've removed the builtin types - the change now looks big but the builtin type removal can be found in this commit |
| return packInt4x8Clamp(unpackedValue); | ||
| } | ||
|
|
||
| // Work-graphs |
There was a problem hiding this comment.
why is work-graph showing up here?
There was a problem hiding this comment.
I added code below work-graphs(which is the last section of the hlsl.meta.slang file) but since the added code is similar to some existing code git treated it as if I moved the work-graphs section up.
Also there seems to be a formatting error, I will push a quick fix.
Related to #6175.
Adds Slang-specific integer pack/unpack intrinsics based on the proposal.
This change is mostly moving the code from the already implemented HLSL pack/unpack intrinsics with code improvements. Floating point intrinsics will be added in a follow-up PR - I am making a separate PR for the integer intrinsics to reduce the size of this follow-up PR.