Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make capability diagnostic message more friendly. #6474

Merged
merged 8 commits into from
Feb 27, 2025
Merged

Make capability diagnostic message more friendly. #6474

merged 8 commits into from
Feb 27, 2025

Conversation

csyonghe
Copy link
Collaborator

Closes #6469.

@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Feb 27, 2025
@csyonghe csyonghe requested a review from a team as a code owner February 27, 2025 05:46
@csyonghe csyonghe mentioned this pull request Feb 27, 2025
Closed
jkwak-work
jkwak-work previously approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@csyonghe csyonghe merged commit 90b3817 into shader-slang:master Feb 27, 2025
15 of 16 checks passed
@csyonghe csyonghe mentioned this pull request Feb 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwak-work jkwak-work jkwak-work left review comments

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad capability diagnostic when a ray tracing shader contains discard.
2 participants
@csyonghe @jkwak-work