lib/chkname.c: is_valid_user_name(): Avoid a cast

By using a temporary vairable, we can remove a cast. Reviewed-by: Iker Pedrosa <[email protected]> Cc: Tobias Stoeckmann <[email protected]> Cc: Serge Hallyn <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
shadow-maint · Feb 13, 2024 · f22ca21 · f22ca21
1 parent ad307ee
commit f22ca21
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/lib/chkname.c b/lib/chkname.c
@@ -76,17 +76,21 @@ static bool is_valid_name (const char *name)
 bool
 is_valid_user_name(const char *name)
 {
-	long  maxsize;
+	long    conf;
+	size_t  maxsize;
 
 	errno = 0;
-	maxsize = sysconf(_SC_LOGIN_NAME_MAX);
-	if (maxsize == -1 && errno != 0)
+	conf = sysconf(_SC_LOGIN_NAME_MAX);
+
+	if (conf == -1 && errno != 0)
 		maxsize = LOGIN_NAME_MAX;
+	else
+		maxsize = conf;
 
-	if (strlen(name) >= (size_t)maxsize)
+	if (strlen(name) >= maxsize)
 		return false;
 
-	return is_valid_name (name);
+	return is_valid_name(name);
 }