Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] libSceNgs2 #439

Merged
merged 16 commits into from
Aug 19, 2024
Merged

[WIP] libSceNgs2 #439

merged 16 commits into from
Aug 19, 2024

Conversation

lzardy
Copy link
Contributor

@lzardy lzardy commented Aug 15, 2024

No description provided.

@georgemoralis
Copy link
Collaborator

seems nice are you going to continue it? If so one adjustment is to load ngs2 library like the others that has lle alternatives in emulator.cpp , so if no lle ngs2 file found it will load the HLE alternative instead.

Surely the purpose is one day to have all the modules in HLE but that will require additional work that will be done a bit later

@lzardy
Copy link
Contributor Author

lzardy commented Aug 18, 2024

seems nice are you going to continue it? If so one adjustment is to load ngs2 library like the others that has lle alternatives in emulator.cpp , so if no lle ngs2 file found it will load the HLE alternative instead.

Surely the purpose is one day to have all the modules in HLE but that will require additional work that will be done a bit later

Yes I will continue it. If it is necessary that development be faster, I can stop here for the review and you can do push to main, so others can contribute to each function.
Otherwise, I can continue on my own to do the system from top down.

@georgemoralis
Copy link
Collaborator

Left some review fixes

src/core/libraries/libs.cpp Outdated Show resolved Hide resolved
src/core/libraries/error_codes.h Outdated Show resolved Hide resolved
@georgemoralis
Copy link
Collaborator

Ok all good now. I guess we can merge it if you want so it will be synced with main and you can open other following pr's for this

@lzardy
Copy link
Contributor Author

lzardy commented Aug 19, 2024

i think it is good enough spot for people to work off of, am okay with merge

@georgemoralis georgemoralis marked this pull request as ready for review August 19, 2024 07:02
@georgemoralis georgemoralis merged commit 138c9ce into shadps4-emu:main Aug 19, 2024
8 checks passed
@lzardy lzardy deleted the ngs2 branch August 19, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants