Move to bluebird promises via bluebird-q #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should migrate from Q to bluebird. The only problem is that some functionality you get from Q is not supported by Bluebird, so I'm afraid it will break users' code. I guess that if we do the migration, increase a major version and document the changes it should be ok. Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had a number of instances where I've been losing exceptions that bluebird picks up with no changes. . Not sure if you are heavily invested in q, but I find bluebird a lot better at error handling and has a few more features. Apparently it's generally faster and consumes less memory as well.
It's a little more work to convert it into straight bluebird promise's, but not much.