Skip to content

Commit

Permalink
ci: Fix workflow events (#83)
Browse files Browse the repository at this point in the history
This was found by auditing workflows based on research published here:

https://github.com/joeyparrish/workflow-cheat-sheet

The research was prompted by a workflow bug in Shaka Streamer
  • Loading branch information
joeyparrish authored Nov 5, 2024
1 parent 1d725d3 commit a1d7279
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ jobs:
id: release
with:
release-type: node
- uses: actions/checkout@v2

- uses: actions/checkout@v4
with:
ref: ${{ github.event.after }}

# If we didn't create a release, we may have created or updated a PR.
- run: |
Expand Down Expand Up @@ -42,8 +45,10 @@ jobs:
node-version: 12
registry-url: 'https://registry.npmjs.org'
if: ${{ steps.release.outputs.release_created }}

- run: npm run build
if: ${{ steps.release.outputs.release_created }}

- uses: svenstaro/upload-release-action@483c1e56f95e88835747b1c7c60581215016cbf2
with:
repo_token: ${{ secrets.GITHUB_TOKEN }}
Expand Down

0 comments on commit a1d7279

Please sign in to comment.