-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: Raise screenshot threshold for native text (#7265)
The screenshots with native text rendering don't always trigger our threshold even when they should. That's because the native text tends to be much smaller. Therefore the matching threshold should be higher to make these smaller regions of text more sensitive to change. This raises the threshold from 95% (still used for DOM-based) to 97% for native text. I believe this could have caught some of the changes that I only caught later with manual review of screenshots. Original author: @joeyparrish Thanks!
- Loading branch information
Showing
54 changed files
with
12 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-44 Bytes
(100%)
test/test/assets/screenshots/chrome-Android/webvtt-native-align-end-long.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+26 Bytes
(100%)
test/test/assets/screenshots/chrome-Android/webvtt-native-size-50.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-19 Bytes
(100%)
test/test/assets/screenshots/chrome-Linux/webvtt-native-align-center-long.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-428 Bytes
(92%)
test/test/assets/screenshots/chrome-Mac/text-displayer-native-basic-cue.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-575 Bytes
(87%)
...test/assets/screenshots/chrome-Mac/text-displayer-native-deeply-nested-cues.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-428 Bytes
(92%)
test/test/assets/screenshots/chrome-Mac/text-displayer-native-duplicate-cues.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-428 Bytes
(92%)
test/test/assets/screenshots/chrome-Mac/text-displayer-native-flat-cue-bg.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-426 Bytes
(92%)
test/test/assets/screenshots/chrome-Mac/text-displayer-native-nested-cue-bg.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-428 Bytes
(92%)
test/test/assets/screenshots/chrome-Mac/text-displayer-native-region-position.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-428 Bytes
(92%)
test/test/assets/screenshots/chrome-Mac/text-displayer-native-two-nested-cues.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-293 Bytes
(98%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-align-center-long.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-658 Bytes
(95%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-align-end-long.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-268 Bytes
(90%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-align-position-line.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-448 Bytes
(97%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-align-start-long.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-424 Bytes
(92%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-classes-with-styles.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-424 Bytes
(92%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-classes.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-101 Bytes
(97%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-embedded-styles.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-432 Bytes
(92%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-escaped-entities.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-353 Bytes
(97%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-italic-long.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-18 Bytes
(99%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-line-0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-94 Bytes
(97%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-region-anchor-top-center.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-94 Bytes
(97%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-region-anchor-top-left.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-94 Bytes
(97%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-region-complex-anchors.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-94 Bytes
(97%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-region-no-anchors.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-599 Bytes
(92%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-size-50.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-424 Bytes
(92%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-voices-with-styles.png
Oops, something went wrong.
Binary file modified
BIN
-424 Bytes
(92%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-voices.png
Oops, something went wrong.
Binary file modified
BIN
-552 Bytes
(82%)
test/test/assets/screenshots/chrome-Mac/webvtt-native-white-spaces.png
Oops, something went wrong.
Binary file modified
BIN
-5 Bytes
(100%)
test/test/assets/screenshots/chrome-Windows/webvtt-native-align-center-long.png
Oops, something went wrong.
Binary file modified
BIN
-99 Bytes
(99%)
test/test/assets/screenshots/chrome-Windows/webvtt-native-align-end-long.png
Oops, something went wrong.
Binary file modified
BIN
-5.89 KB
(77%)
test/test/assets/screenshots/firefox-Mac/webvtt-ui-region-2-lines-scroll-up.png
Oops, something went wrong.
Binary file modified
BIN
-8.13 KB
(77%)
test/test/assets/screenshots/firefox-Mac/webvtt-ui-underline-long.png
Oops, something went wrong.
Binary file modified
BIN
-19 Bytes
(100%)
test/test/assets/screenshots/msedge-Linux/webvtt-native-align-center-long.png
Oops, something went wrong.
Binary file modified
BIN
-417 Bytes
(92%)
test/test/assets/screenshots/msedge-Mac/text-displayer-native-basic-cue.png
Oops, something went wrong.
Binary file modified
BIN
-417 Bytes
(92%)
test/test/assets/screenshots/msedge-Mac/text-displayer-native-duplicate-cues.png
Oops, something went wrong.
Binary file modified
BIN
-417 Bytes
(92%)
test/test/assets/screenshots/msedge-Mac/text-displayer-native-flat-cue-bg.png
Oops, something went wrong.
Binary file modified
BIN
-422 Bytes
(92%)
test/test/assets/screenshots/msedge-Mac/text-displayer-native-nested-cue-bg.png
Oops, something went wrong.
Binary file modified
BIN
-417 Bytes
(92%)
test/test/assets/screenshots/msedge-Mac/text-displayer-native-region-position.png
Oops, something went wrong.
Binary file modified
BIN
-417 Bytes
(92%)
test/test/assets/screenshots/msedge-Mac/text-displayer-native-two-nested-cues.png
Oops, something went wrong.
Binary file modified
BIN
-488 Bytes
(96%)
test/test/assets/screenshots/msedge-Mac/webvtt-native-align-center-long.png
Oops, something went wrong.
Binary file modified
BIN
-216 Bytes
(92%)
test/test/assets/screenshots/msedge-Mac/webvtt-native-align-position-line.png
Oops, something went wrong.
Binary file modified
BIN
-261 Bytes
(98%)
test/test/assets/screenshots/msedge-Mac/webvtt-native-align-start-long.png
Oops, something went wrong.
Binary file modified
BIN
-186 Bytes
(99%)
test/test/assets/screenshots/msedge-Mac/webvtt-native-bold-long.png
Oops, something went wrong.
Binary file modified
BIN
-540 Bytes
(90%)
test/test/assets/screenshots/msedge-Mac/webvtt-native-classes-with-styles.png
Oops, something went wrong.
Binary file modified
BIN
-540 Bytes
(90%)
test/test/assets/screenshots/msedge-Mac/webvtt-native-classes.png
Oops, something went wrong.
Binary file modified
BIN
-418 Bytes
(92%)
test/test/assets/screenshots/msedge-Mac/webvtt-native-escaped-entities.png
Oops, something went wrong.
Binary file modified
BIN
-233 Bytes
(98%)
test/test/assets/screenshots/msedge-Mac/webvtt-native-italic-long.png
Oops, something went wrong.
Binary file modified
BIN
-429 Bytes
(97%)
test/test/assets/screenshots/msedge-Mac/webvtt-native-underline-long.png
Oops, something went wrong.
Binary file modified
BIN
-540 Bytes
(90%)
test/test/assets/screenshots/msedge-Mac/webvtt-native-voices-with-styles.png
Oops, something went wrong.
Binary file modified
BIN
-540 Bytes
(90%)
test/test/assets/screenshots/msedge-Mac/webvtt-native-voices.png
Oops, something went wrong.
Binary file modified
BIN
-5 Bytes
(100%)
test/test/assets/screenshots/msedge-Windows/webvtt-native-align-center-long.png
Oops, something went wrong.
Binary file modified
BIN
-99 Bytes
(99%)
test/test/assets/screenshots/msedge-Windows/webvtt-native-align-end-long.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters