Skip to content

Commit

Permalink
chore: Remove old comment (#6512)
Browse files Browse the repository at this point in the history
The playhead test, "does not change once the initial position is set", is not really as important as it was when it was first added. The playhead class has been refactored significantly since then, and drift tolerance has been improved (see #999).

However, the behavior of the getTime method not changing until the video starts... it's not something we would write a test for today, perhaps, but it's still worthwhile enough to at least keep. Perhaps if it was a slow integration test it'd be worth trimming, but as a simple synchronous unit test it won't have any major effects on the durations of test runs.

Closes #1754
  • Loading branch information
theodab authored Apr 30, 2024
1 parent 156893f commit 4365b84
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion test/media/playhead_unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,6 @@ describe('Playhead', () => {

// This is important for recovering from drift.
// See: https://github.com/shaka-project/shaka-player/issues/1105
// TODO: Re-evaluate after https://github.com/shaka-project/shaka-player/issues/999
it('does not change once the initial position is set', () => {
timeline.isLive.and.returnValue(true);
timeline.getDuration.and.returnValue(Infinity);
Expand Down

0 comments on commit 4365b84

Please sign in to comment.