fix: Fix ID3 timing when included in EMSG (#7099)

Related to #7097
shaka-project · Jul 24, 2024 · eb36c0d · eb36c0d
1 parent dcdecf9
commit eb36c0d
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/lib/media/streaming_engine.js b/lib/media/streaming_engine.js
@@ -2317,10 +2317,11 @@ shaka.media.StreamingEngine = class {
         this.playerInterface_.onManifestUpdate();
       } else {
         // All other schemes are dispatched as a general 'emsg' event.
+        const endTime = startTime + (eventDuration / timescale);
         /** @type {shaka.extern.EmsgInfo} */
         const emsg = {
           startTime: startTime,
-          endTime: startTime + (eventDuration / timescale),
+          endTime: endTime,
           schemeIdUri: schemeId,
           value: value,
           timescale: timescale,
@@ -2353,17 +2354,17 @@ shaka.media.StreamingEngine = class {
             schemeId == 'https://developer.apple.com/streaming/emsg-id3') {
           // See https://aomediacodec.github.io/id3-emsg/
           const frames = shaka.util.Id3Utils.getID3Frames(messageData);
-          if (frames.length && reference) {
+          if (frames.length) {
             /** @private {shaka.extern.ID3Metadata} */
             const metadata = {
-              cueTime: reference.startTime,
+              cueTime: startTime,
               data: messageData,
               frames: frames,
-              dts: reference.startTime,
-              pts: reference.startTime,
+              dts: startTime,
+              pts: startTime,
             };
             this.playerInterface_.onMetadata(
-                [metadata], /* offset= */ 0, reference.endTime);
+                [metadata], /* offset= */ 0, endTime);
           }
         }
       }