Introduce before_request configuration #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainEndelin
force-pushed
the
authenticate
branch
2 times, most recently
from
b9302bb to
b8c40bb
Compare
|
👋 I've been able to test it in my repository, and it worked: passed when authenticated, rejected with expected status when unauthenticated. I'm not sure whether to add tests to |
RomainEndelin
force-pushed
the
authenticate
branch
from
b8c40bb to
cd34512
Compare
|
Thanks @RomainEndelin! Looks solid. Check this out @grantspeelman. |
grantspeelman
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #137
Add a
before_request: -> (env) { ... }configuration option. This option can be useful for users to authenticate their calls, add metrics, etc.