-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump major versions of client dependencies #529
Merged
Commits on Aug 10, 2023
-
chore: bump major versions of client dependencies
1. Bump all minor and patch versions of all packages. 2. Upgrade `autoprefixer`: Use `.browserslistrc` and delete `.postcssrc` Add it to `postcss.config.js` Install and add `postcss-preset-env` to `postcss.config.js` 3. Upgrade `immutable`: Explicitly convert all `Array`s to `List`s 4. Upgrae `marked`: Install `marked-gfm-heading-id` to support `gfm` opt 5. Upgrade `react-router`: a. Remove `exact` b. Use `Routes` instead of `Switch`. c. Import `StaticRouter` from `react-router-dom/server`. d. Use `element` instead of `component` e. Use absolute paths instead of relative in Links. f. Convert Two Components to Functional React ones in order to use `useLocation` hook. g. Use `isActive` in `className` instead of `activeClassName`. h. Use `Navigate` instead of `Redirect`. i. Reset state once redirected. 6. Upgrade `react-transition-group`: a. Use `TransitionGroup` and `CSSTransition` instead of `ReactCSSTransitionGroup`. b. Convert one component to a Functional React one to use `forwardRef` c. Add `nodeRef` as part of the state to track DOM nodes for animation 7. Install `typescript` because it's a needed peer depenency of `prettier-eslint-cli` Signed-off-by: Khaled Emara <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bde133a - Browse repository at this point
Copy the full SHA bde133aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ad4cab - Browse repository at this point
Copy the full SHA 8ad4cabView commit details -
Configuration menu - View commit details
-
Copy full SHA for d160ee8 - Browse repository at this point
Copy the full SHA d160ee8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37bcfca - Browse repository at this point
Copy the full SHA 37bcfcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f2fe92 - Browse repository at this point
Copy the full SHA 6f2fe92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e30e07 - Browse repository at this point
Copy the full SHA 1e30e07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4223647 - Browse repository at this point
Copy the full SHA 4223647View commit details -
Move the comment component ref to CommentList
This commit solve the warning of unexpected ref object provided for a div.
Configuration menu - View commit details
-
Copy full SHA for 907295a - Browse repository at this point
Copy the full SHA 907295aView commit details -
- Since we create the comment nodeRef in the CommentList component We don’t need it to be created during adding a comment. - We shouldn’t change the props of a react component, It is not the best practice, So that this commit creates the nodeRef in the render function where it is used instead of the constructor function.
Configuration menu - View commit details
-
Copy full SHA for 8c13893 - Browse repository at this point
Copy the full SHA 8c13893View commit details
Commits on Aug 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e849ebf - Browse repository at this point
Copy the full SHA e849ebfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.