Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace marked sanitize with sanitize-html (#500) #535

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

Yassa-hue
Copy link
Contributor

@Yassa-hue Yassa-hue commented Jul 25, 2023

Because the sanitize option in marked is deprecated and not safe This commit replace it with sanitize-html which works well with Server Side Rendering unlike DOMPurify.

Resolves #500


This change is Reviewable

Because the sanitize option in marked is deprecated and not safe
This commit replace it with sanitize-html which works well with
Server Side Rendering unlike DOMPurify.

Resolves shakacode#500
@Yassa-hue Yassa-hue requested a review from ahangarha July 25, 2023 06:04
Copy link
Contributor

@ahangarha ahangarha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice small improvement 👍🏾

@justin808 justin808 merged commit 11e5050 into shakacode:master Jul 25, 2023
1 check passed
@justin808
Copy link
Member

Nice job @Yassa-hue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component Comment.jsx is using an insecure method to sanitize input --could suffer XSS atacks
3 participants